Skip to content

bpo-40077: Convert _abc module to use PyType_FromSpec() #19202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 8 commits into from
Mar 30, 2020
Merged

bpo-40077: Convert _abc module to use PyType_FromSpec() #19202

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
47eb700
bpo-40077: Convert _abc module to use PyType_FromSpec()
corona10 Mar 28, 2020
7756065
bpo-40077: rename
corona10 Mar 28, 2020
ec8ccc6
bpo-40077: Update test_abc.py
corona10 Mar 29, 2020
c2ade98
bpo-40077: Add comment for abc_invalidation_counter.
corona10 Mar 29, 2020
0c0a895
Update Modules/_abc.c
corona10 Mar 30, 2020
32eaf52
bpo-40077: Remove NEWS.d
corona10 Mar 30, 2020
98b9300
bpo-40077: Apply code review.
corona10 Mar 30, 2020
14c3e52
bpo-40077: Update the type of _abc_data_type.
corona10 Mar 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
bpo-40077: Update test_abc.py
  • Loading branch information
@corona10
corona10 committed Mar 29, 2020
commit ec8ccc659d3e75bd45c2cd1ffbe947f7fde2a3a3
2 changes: 1 addition & 1 deletion Lib/test/test_abc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,7 @@ class B:
token_old = abc_get_cache_token()
A.register(B)
token_new = abc_get_cache_token()
self.assertNotEqual(token_old, token_new)
self.assertGreater(token_new, token_old)
Copy link
Copy Markdown
Member Author

@corona10 corona10 Mar 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test might be what we wanted exactly.
I just updated the test for more validation.

self.assertTrue(isinstance(b, A))
self.assertTrue(isinstance(b, (A,)))

Expand Down