Skip to content

bpo-39652: Truncate the column name after '[' only if PARSE_COLNAMES is set.#18942

Merged
serhiy-storchaka merged 1 commit into
python:masterfrom
serhiy-storchaka:sqlite-parse-colname
Mar 21, 2020
Merged

bpo-39652: Truncate the column name after '[' only if PARSE_COLNAMES is set.#18942
serhiy-storchaka merged 1 commit into
python:masterfrom
serhiy-storchaka:sqlite-parse-colname

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Mar 11, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@serhiy-storchaka serhiy-storchaka merged commit b146568 into python:master Mar 21, 2020
@serhiy-storchaka serhiy-storchaka deleted the sqlite-parse-colname branch March 21, 2020 14:02
@miss-islington

miss-islington commented Mar 21, 2020

Copy link
Copy Markdown
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Mar 21, 2020

Copy link
Copy Markdown
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Mar 21, 2020

Copy link
Copy Markdown
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker b146568dfcbcd7409c724f8917e4f77433dd56e4 3.7

@miss-islington

miss-islington commented Mar 21, 2020

Copy link
Copy Markdown
Contributor

Sorry @serhiy-storchaka, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker b146568dfcbcd7409c724f8917e4f77433dd56e4 3.8

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Mar 21, 2020
@serhiy-storchaka
[3.8] bpo-39652: Truncate the column name after '[' only if PARSE_COL…
af157d7 
…NAMES is set. (pythonGH-18942)

(cherry picked from commit b146568)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@miss-islington

miss-islington commented Mar 21, 2020

Copy link
Copy Markdown
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented Mar 21, 2020

Copy link
Copy Markdown

GH-19103 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 21, 2020
@serhiy-storchaka @miss-islington
bpo-39652: Truncate the column name after '[' only if PARSE_COLNAMES …
a68d54d 
…is set. (pythonGH-18942)

(cherry picked from commit b146568)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@miss-islington

miss-islington commented Mar 21, 2020

Copy link
Copy Markdown
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Mar 21, 2020

Copy link
Copy Markdown
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker b146568dfcbcd7409c724f8917e4f77433dd56e4 3.7

@bedevere-bot

bedevere-bot commented Mar 21, 2020

Copy link
Copy Markdown

GH-19104 is a backport of this pull request to the 3.7 branch.

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Mar 21, 2020
@serhiy-storchaka
[3.7] bpo-39652: Truncate the column name after '[' only if PARSE_COL…
c98bc49 
…NAMES is set. (pythonGH-18942).

(cherry picked from commit b146568)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington added a commit that referenced this pull request Mar 21, 2020
@miss-islington @serhiy-storchaka
bpo-39652: Truncate the column name after '[' only if PARSE_COLNAMES …
687f592 
…is set. (GH-18942)

(cherry picked from commit b146568)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit that referenced this pull request Mar 21, 2020
@serhiy-storchaka
[3.7] bpo-39652: Truncate the column name after '[' only if PARSE_COL…
39680fb 
…NAMES is set. (GH-18942). (GH-19104)

(cherry picked from commit b146568)
@serhiy-storchaka serhiy-storchaka removed their assignment Dec 29, 2020
@eLRuLL eLRuLL mentioned this pull request Jan 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@serhiy-storchaka @miss-islington @bedevere-bot @the-knights-who-say-ni