Skip to content

bpo-39901: Move pathlib.Path.owner() and group() implementations into the path accessor #18844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pitrou merged 1 commit into from
Apr 17, 2020
Merged

bpo-39901: Move pathlib.Path.owner() and group() implementations into the path accessor #18844

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
bpo-39901: Move pathlib.Path.owner() and group() implementations … 
…into the path accessor.
  • Loading branch information
@barneygale
barneygale committed Mar 8, 2020
commit 7437fb5410c4362dd917de8fbb4ceb79e2d903c9
26 changes: 16 additions & 10 deletions Lib/pathlib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -447,6 +447,20 @@ def symlink(a, b, target_is_directory):
def readlink(self, path):
return os.readlink(path)

def owner(self, path):
try:
import pwd
return pwd.getpwuid(self.stat(path).st_uid).pw_name
except ImportError:
raise NotImplementedError("Path.owner() is unsupported on this system")

def group(self, path):
try:
import grp
return grp.getgrgid(self.stat(path).st_gid).gr_name
except ImportError:
raise NotImplementedError("Path.group() is unsupported on this system")


_normal_accessor = _NormalAccessor()

Expand Down Expand Up @@ -1209,15 +1223,13 @@ def owner(self):
"""
Return the login name of the file owner.
"""
import pwd
return pwd.getpwuid(self.stat().st_uid).pw_name
return self._accessor.owner(self)

def group(self):
"""
Return the group name of the file gid.
"""
import grp
return grp.getgrgid(self.stat().st_gid).gr_name
return self._accessor.group(self)

def open(self, mode='r', buffering=-1, encoding=None,
errors=None, newline=None):
Expand Down Expand Up @@ -1575,11 +1587,5 @@ class WindowsPath(Path, PureWindowsPath):
"""
__slots__ = ()

def owner(self):
raise NotImplementedError("Path.owner() is unsupported on this system")

def group(self):
raise NotImplementedError("Path.group() is unsupported on this system")

def is_mount(self):
raise NotImplementedError("Path.is_mount() is unsupported on this system")