Skip to content

bpo-39699: Don't silence make on Azure and Github CIs#18583

Merged
zooba merged 2 commits into
python:masterfrom
ammaraskar:non_silent_make
Feb 26, 2020
Merged

bpo-39699: Don't silence make on Azure and Github CIs#18583
zooba merged 2 commits into
python:masterfrom
ammaraskar:non_silent_make

Conversation

@ammaraskar

@ammaraskar ammaraskar commented Feb 20, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

Removing the -s flag allows us to see what build commands were invoked to produce the targets and which compilation step produced errors/warnings.

https://bugs.python.org/issue39699

@ammaraskar ammaraskar requested a review from zooba February 20, 2020 23:35
@codecov

codecov Bot commented Feb 21, 2020

Copy link
Copy Markdown

Codecov Report

Merging #18583 into master will increase coverage by 1.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #18583       +/-   ##
===========================================
+ Coverage   82.11%   83.13%    +1.01%     
===========================================
  Files        1956     1571      -385     
  Lines      589357   414787   -174570     
  Branches    44458    44458               
===========================================
- Hits       483953   344827   -139126     
+ Misses      95756    60336    -35420     
+ Partials     9648     9624       -24
Impacted Files Coverage Δ
Lib/distutils/tests/test_bdist_rpm.py 30.00% <0.00%> (-65.00%) ⬇️
Lib/distutils/command/bdist_rpm.py 7.63% <0.00%> (-56.88%) ⬇️
Lib/test/test_urllib2net.py 76.92% <0.00%> (-13.85%) ⬇️
Lib/test/test_smtpnet.py 78.57% <0.00%> (-7.15%) ⬇️
Lib/ftplib.py 63.85% <0.00%> (-6.06%) ⬇️
Lib/test/test_ftplib.py 87.11% <0.00%> (-4.72%) ⬇️
Tools/scripts/db2pickle.py 17.82% <0.00%> (-3.97%) ⬇️
Tools/scripts/pickle2db.py 16.98% <0.00%> (-3.78%) ⬇️
Lib/test/test_socket.py 71.94% <0.00%> (-3.77%) ⬇️
Lib/test/test_asyncio/test_base_events.py 91.84% <0.00%> (-3.30%) ⬇️
... and 435 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c444d0...54bf371. Read the comment docs.

zooba
zooba reviewed Feb 21, 2020
View reviewed changes
Comment thread .github/workflows/build.yml
@zooba

zooba commented Feb 21, 2020

Copy link
Copy Markdown
Member

With the macOS fix I mentioned in the comment, I approve of this PR. Whoever is around can feel free to merge it.

@ammaraskar

ammaraskar commented Feb 22, 2020

Copy link
Copy Markdown
Member Author

Thanks for the review Steve! :)

@zooba zooba merged commit 6aa1f1e into python:master Feb 26, 2020
@miss-islington

miss-islington commented Feb 26, 2020

Copy link
Copy Markdown
Contributor

Thanks @ammaraskar for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Feb 26, 2020

Copy link
Copy Markdown
Contributor

Sorry, @ammaraskar and @zooba, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 6aa1f1ecf7142a4117eedb8c570f30da1598616c 3.8

@miss-islington

miss-islington commented Feb 26, 2020

Copy link
Copy Markdown
Contributor

Sorry @ammaraskar and @zooba, I had trouble checking out the 3.7 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 6aa1f1ecf7142a4117eedb8c570f30da1598616c 3.7

zooba pushed a commit to zooba/cpython that referenced this pull request Feb 26, 2020
@ammaraskar @zooba
bpo-39699: Don't silence make on Azure and Github CIs (pythonGH-18583)
d75331f
zooba pushed a commit to zooba/cpython that referenced this pull request Feb 26, 2020
@ammaraskar @zooba
bpo-39699: Don't silence make on Azure and Github CIs (pythonGH-18583)
b36bbce
@bedevere-bot

bedevere-bot commented Feb 26, 2020

Copy link
Copy Markdown

GH-18670 is a backport of this pull request to the 3.8 branch.

@bedevere-bot

bedevere-bot commented Feb 26, 2020

Copy link
Copy Markdown

GH-18671 is a backport of this pull request to the 3.7 branch.

zooba added a commit that referenced this pull request Feb 26, 2020
@zooba @ammaraskar
bpo-39699: Don't silence make on Azure and Github CIs (GH-18583)
343bc06 
Co-authored-by: Ammar Askar <ammar_askar@hotmail.com>
zooba added a commit that referenced this pull request Feb 26, 2020
@zooba @ammaraskar
bpo-39699: Don't silence make on Azure and Github CIs (GH-18583)
3bf9de2 
Doc tests remain disabled for 3.7

Co-authored-by: Ammar Askar <ammar_askar@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zooba zooba zooba left review comments

Assignees

@zooba zooba

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ammaraskar @zooba @miss-islington @bedevere-bot @the-knights-who-say-ni