bpo-39627: Fix TypedDict totality check for inherited keys#18503
Merged
gvanrossum merged 3 commits intopython:masterfrom Feb 13, 2020
Merged
bpo-39627: Fix TypedDict totality check for inherited keys#18503gvanrossum merged 3 commits intopython:masterfrom
gvanrossum merged 3 commits intopython:masterfrom
Conversation
Member
|
Can you fix the test? To run locally, build Also, please add a news item, and a reference to the fix in the python/typing repo. |
Contributor
Author
|
I forgot to copy a couple of lines, now tests are passing. |
|
@gvanrossum: Please replace |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I realized that the inheritance of
TypedDictdoes not work as it should.I would assume that
Catshould have required keysnameandfur_colorand optionalvoice.But in reality, it will have required
fur_colorand optionalnameandvoice, becauseAnimalhastotal=FalseFixed
__required_keys__and__optional_keys__are copied from base classesTypedDictannotations are added to__annotations__after base annotationshttps://bugs.python.org/issue39627