bpo-35182: fix communicate() crash after child closes its pipes#18117
Conversation
…7020) When communicate() is called in a loop, it crashes when the child process has already closed any piped standard stream, but still continues to be running
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). CLA MissingOur records indicate the following people have not signed the CLA: For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
|
I'm having trouble backporting to |
|
Sorry, @alpire and @gpshead, I could not cleanly backport this to |
|
Sorry @alpire and @gpshead, I had trouble checking out the |
|
Sorry, @alpire and @gpshead, I could not cleanly backport this to |
|
GH-18148 is a backport of this pull request to the 3.8 branch. |
|
GH-18151 is a backport of this pull request to the 3.7 branch. |
…GH-18117) (GH-18148) When communicate() is called in a loop, it crashes when the child process has already closed any piped standard stream, but still continues to be running Co-authored-by: Andriy Maletsky <andriy.maletsky@gmail.com>. (cherry picked from commit d3ae95e) Co-authored-by: Alex Rebert <alex@forallsecure.com> https://bugs.python.org/issue35182
…GH-18117) (GH-18151) When communicate() is called in a loop, it crashes when the child process has already closed any piped standard stream, but still continues to be running Co-authored-by: Andriy Maletsky <andriy.maletsky@gmail.com>. (cherry picked from commit d3ae95e) Co-authored-by: Alex Rebert <alex@forallsecure.com> https://bugs.python.org/issue35182 Automerge-Triggered-By: @gpshead
…onGH-17020) (pythonGH-18117) When communicate() is called in a loop, it crashes when the child process has already closed any piped standard stream, but still continues to be running Co-authored-by: Andriy Maletsky <andriy.maletsky@gmail.com>
When communicate() is called in a loop, it crashes when the child process has already closed any piped standard stream, but still continues to be running. The fix is trivial.
(Original PR is #17020. I had to create a new one to rebase on top of master & fix merge conflicts)
https://bugs.python.org/issue35182