Skip to content

bpo-39184: Add audit events to command execution functions in os and pty modules#17824

Merged
zooba merged 3 commits into
python:masterfrom
gousaiyang:bpo-39184
Feb 5, 2020
Merged

bpo-39184: Add audit events to command execution functions in os and pty modules#17824
zooba merged 3 commits into
python:masterfrom
gousaiyang:bpo-39184

Conversation

@gousaiyang
Copy link
Copy Markdown
Contributor

@gousaiyang gousaiyang commented Jan 4, 2020 •
edited by bedevere-bot
Loading

Add audit events to the following functions:

  • os.exec*
  • os.spawn*
  • os.posix_spawn*
  • os.startfile
  • pty.spawn

https://bugs.python.org/issue39184

https://bugs.python.org/issue39184

@the-knights-who-say-ni
Copy link
Copy Markdown

the-knights-who-say-ni commented Jan 4, 2020

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@gousaiyang

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@terryjreedy terryjreedy requested review from zooba and removed request for 1st1, asvetlov, ethanfurman and terryjreedy January 8, 2020 21:11
@terryjreedy
Copy link
Copy Markdown
Member

terryjreedy commented Jan 8, 2020

I was about to close this and tell you to start over with a new PR, but you seem to have corrected it. In the future, do not hit the green [Make Pull Request] button unless the list of commits only has your commits and not those of others. Also, fix the list of suggested reviewers when needed.

@gousaiyang
Copy link
Copy Markdown
Contributor Author

gousaiyang commented Jan 8, 2020

Sorry about this, the review request was automatically triggered by the system. I messed up with this branch (should not fetch changes by others) and fixed it by force push.

@zooba
Copy link
Copy Markdown
Member

zooba commented Feb 5, 2020

Thanks! These look great!

@zooba zooba merged commit 95f6001 into python:master Feb 5, 2020
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Feb 5, 2020

Thanks @gousaiyang for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Feb 5, 2020

Sorry @gousaiyang and @zooba, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 95f60010219e142a436fae18e1695cbc45407afe 3.8

@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Feb 5, 2020

Thanks @gousaiyang for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 5, 2020
@gousaiyang @miss-islington
bpo-39184: Add audit events to command execution functions in os and …
b46dd9b 
…pty modules (pythonGH-17824)

(cherry picked from commit 95f6001)

Co-authored-by: Saiyang Gou <gousaiyang@163.com>
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Feb 5, 2020

GH-18353 is a backport of this pull request to the 3.8 branch.

@gousaiyang gousaiyang deleted the bpo-39184 branch February 5, 2020 00:22
miss-islington added a commit that referenced this pull request Feb 5, 2020
@miss-islington @gousaiyang
bpo-39184: Add audit events to command execution functions in os and …
3498ac5 
…pty modules (GH-17824)

(cherry picked from commit 95f6001)

Co-authored-by: Saiyang Gou <gousaiyang@163.com>
@gousaiyang gousaiyang mannequin mentioned this pull request Apr 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zooba zooba Awaiting requested review from zooba

Assignees

@zooba zooba

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@gousaiyang @the-knights-who-say-ni @terryjreedy @zooba @miss-islington @bedevere-bot