bpo-9146: Raise a ValueError if OpenSSL fails to init a hash function#1777
Merged
Conversation
This helps people in weird FIPS mode environments where common things like MD5 are not available in the binary as a matter of policy.
|
@gpshead, thanks for your PR! By analyzing the history of the files in this pull request, we identified @loewis, @tiran and @teoliphant to be potential reviewers. |
tiran
approved these changes
May 23, 2017
tiran
left a comment
Member
There was a problem hiding this comment.
LGTM
test_hashlib passes with OpenSSL 0.9.8zh, 1.0.1u, 1.0.2k, 1.1.0e, LibreSSL 2.3.10, 2.4.5, 2,5.3
Member
Author
|
assigning to tiran for the backports. |
gpshead
added a commit
to gpshead/cpython
that referenced
this pull request
Sep 3, 2017
…nc. (pythonGH-1777) This helps people in weird FIPS mode environments where common things like MD5 are not available in the binary as a matter of policy. (cherry picked from commit 07244a8)
Member
Author
|
looks like we still need a Misc/NEWS.d entry for this |
Contributor
|
Thanks @gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7. |
Contributor
|
Sorry, @gpshead, I could not cleanly backport this to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This helps people in weird FIPS mode environments where common algorithms
such as MD5 or SHA1 are not available in the binary as a matter of policy.
This is https://bugs.python.org/file46765/hashopenssl-fips-exceptions.patch from bpo by @kscguru.