Skip to content

Fixed a typo in the HTMLParser.feed docstrings#1759

Merged
serhiy-storchaka merged 1 commit into
python:masterfrom
dasdachs:fix-html-parser-docstring-typo
May 23, 2017
Merged

Fixed a typo in the HTMLParser.feed docstrings#1759
serhiy-storchaka merged 1 commit into
python:masterfrom
dasdachs:fix-html-parser-docstring-typo

Conversation

@dasdachs
Copy link
Copy Markdown
Contributor

The docstring started with an 'r', like a rawstring.

@mention-bot
Copy link
Copy Markdown

@dasdachs, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ezio-melotti, @freddrake and @bitdancer to be potential reviewers.

@the-knights-who-say-ni
Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@serhiy-storchaka serhiy-storchaka merged commit 5ba1850 into python:master May 23, 2017
@serhiy-storchaka
Copy link
Copy Markdown
Member

Thank you for your patch @dasdachs. Do you mind to backport your change to other active branches (3.6, 3.5, and maybe 2.7)?

@dasdachs
Copy link
Copy Markdown
Contributor Author

Thank you @serhiy-storchaka! I'll backport the changes as soon as I can.

@vadmium
Copy link
Copy Markdown
Member

vadmium commented May 23, 2017

This looks wrong to me. It looks like it will have a real newline rather than the literal \n escape sequence. See commit 39f180b.

@serhiy-storchaka
Copy link
Copy Markdown
Member

Oh, my bad! I read the patch as adding the "r" prefix!

serhiy-storchaka added a commit that referenced this pull request May 23, 2017
… started with an 'r', like a rawstring. (#1759)"

This reverts commit 5ba1850.
@dasdachs
Copy link
Copy Markdown
Contributor Author

Of course it does. Sorry for the unnecesary work @serhiy-storchaka and thank you @vadmium!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants