remove unnecesary variable definition#17368
Merged
pablogsal merged 1 commit intopython:masterfrom Nov 24, 2019
Merged
Conversation
corona10
approved these changes
Nov 24, 2019
Member
corona10
left a comment
There was a problem hiding this comment.
@isidentical
Thanks for the contribution :)
Since the defaults was double declared.
PR looks good to me.
@pablogsal
Please take a look @isidentical 's PR as the core developer :)
Please note that 3.8 and 3.7 also have the same issue.
Member
|
Thanks for the PR @isidentical and for the review @corona10. Notice that we should not backport this to older versions as only bugfixes and security fixes should be backported. The reason is that any other change backported increases potentially the posibilities of regressions. |
jacobneiltaylor
pushed a commit
to jacobneiltaylor/cpython
that referenced
this pull request
Dec 5, 2019
shihai1991
pushed a commit
to shihai1991/cpython
that referenced
this pull request
Jan 31, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please label this with
skip-newsandskip-issue