bpo-38657: Clarify numeric padding behaviour in string formatting#17036
Conversation
Make the definition of the width more explicit that it includes any extra signs added by other options.
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). CLA MissingOur records indicate the following people have not signed the CLA: For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
|
Thanks for your time @JamoBox, and welcome to CPython! 😎 I assume that you've seen the bot's message about the CLA? |
brandtbucher
left a comment
There was a problem hiding this comment.
I have one suggestion, but otherwise this looks good:
Co-Authored-By: Brandt Bucher <brandtbucher@gmail.com>
I've signed the CLA, although it hasn't updated yet. |
Great, that works perfectly. I've added it in, thanks. |
|
Great! Can you re-wrap the line, too? |
Signed-off-by: Pete Wicken <petewicken@gmail.com>
This reverts commit 4996e98.
Signed-off-by: Pete Wicken <petewicken@gmail.com>
|
Thanks @JamoBox for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8. |
|
GH-18587 is a backport of this pull request to the 3.8 branch. |
|
GH-18588 is a backport of this pull request to the 3.7 branch. |
…thonGH-17036) Make the definition of the width more explicit that it includes any extra signs added by other options. https://bugs.python.org/issue38657 Automerge-Triggered-By: @Mariatta (cherry picked from commit 424e568) Co-authored-by: Pete Wicken <2273100+JamoBox@users.noreply.github.com>
…-17036) Make the definition of the width more explicit that it includes any extra signs added by other options. https://bugs.python.org/issue38657 Automerge-Triggered-By: @Mariatta (cherry picked from commit 424e568) Co-authored-by: Pete Wicken <2273100+JamoBox@users.noreply.github.com>
…-17036) Make the definition of the width more explicit that it includes any extra signs added by other options. https://bugs.python.org/issue38657 Automerge-Triggered-By: @Mariatta (cherry picked from commit 424e568) Co-authored-by: Pete Wicken <2273100+JamoBox@users.noreply.github.com>
|
Congrats on your first CPython contribution @JamoBox! 🍾 Looking forward to seeing more from you in the future. |
Make the definition of the width more explicit that it includes any
extra signs added by other options.
https://bugs.python.org/issue38657
Automerge-Triggered-By: @Mariatta