Skip to content

bpo-30456: DOC: 2to3: fix example for duplicates in second argument of isinstance#1699

Merged
berkerpeksag merged 2 commits into
python:masterfrom
eli-b:patch-1
Jul 24, 2017
Merged

bpo-30456: DOC: 2to3: fix example for duplicates in second argument of isinstance#1699
berkerpeksag merged 2 commits into
python:masterfrom
eli-b:patch-1

Conversation

@eli-b
Copy link
Copy Markdown
Contributor

@eli-b eli-b commented May 21, 2017

No description provided.

@mention-bot
Copy link
Copy Markdown

mention-bot commented May 21, 2017

@eli-b, thanks for your PR! By analyzing the history of the files in this pull request, we identified @benjaminp, @vadmium and @gpshead to be potential reviewers.

@the-knights-who-say-ni
Copy link
Copy Markdown

the-knights-who-say-ni commented May 21, 2017

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA. This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@eli-b eli-b changed the title 2to3: fix example for duplicates in second argument of isinstance DOC: 2to3: fix example for duplicates in second argument of isinstance May 21, 2017
@eli-b eli-b changed the title DOC: 2to3: fix example for duplicates in second argument of isinstance bpo-30456: DOC: 2to3: fix example for duplicates in second argument of isinstance May 24, 2017
DimitrisJim
DimitrisJim approved these changes May 26, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though isinstance(x, (int)) is equivalent to isinstance(x, int) I can see how this might be confusing. Adding the other example also helps imho.

@berkerpeksag berkerpeksag merged commit 26248ef into python:master Jul 24, 2017
@berkerpeksag
Copy link
Copy Markdown
Member

berkerpeksag commented Jul 24, 2017

Thanks!

berkerpeksag pushed a commit to berkerpeksag/cpython that referenced this pull request Nov 23, 2017
@eli-b @berkerpeksag
bpo-30456: Clarify example for duplicates in second argument of isins…
c1c68b7 
…tance (pythonGH-1699)

(cherry picked from commit 26248ef)
berkerpeksag added a commit that referenced this pull request Nov 23, 2017
@berkerpeksag
bpo-30456: Clarify example for duplicates in second argument of isins…
a645b23 
…tance (GH-1699)

(cherry picked from commit 26248ef)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@berkerpeksag berkerpeksag berkerpeksag approved these changes

+1 more reviewer

@DimitrisJim DimitrisJim DimitrisJim approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@eli-b @mention-bot @the-knights-who-say-ni @berkerpeksag @DimitrisJim