Skip to content

bpo-38629: implement __floor__ and __ceil__ for float #16985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 3 commits into from
Dec 15, 2019
Merged

bpo-38629: implement __floor__ and __ceil__ for float #16985

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0b36750
bpo-38629: implement __floor__ and __ceil__ for float
isidentical Oct 29, 2019
e1ac18c
update generated files
isidentical Oct 30, 2019
40db4db
use PyFloat_AS_DOUBLE for getting direct value without checking
isidentical Oct 31, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
use PyFloat_AS_DOUBLE for getting direct value without checking
  • Loading branch information
@isidentical
isidentical committed Dec 3, 2019
commit 40db4db4ef5fa6d2e775d8d3846327f56c89b13b
3 changes: 1 addition & 2 deletions Misc/NEWS.d/next/Core and Builtins/2019-10-29-17-11-15.bpo-38629.3qinhF.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
Implementation of missing floor and ceil methods to float object -- by
Batuhan Taskaya.
Added ``__floor__`` and ``__ceil__`` methods to float object. Patch by Batuhan Taşkaya.
4 changes: 2 additions & 2 deletions Objects/floatobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -933,7 +933,7 @@ static PyObject *
float___floor___impl(PyObject *self)
/*[clinic end generated code: output=e0551dbaea8c01d1 input=77bb13eb12e268df]*/
{
double x = PyFloat_AsDouble(self);
double x = PyFloat_AS_DOUBLE(self);
return PyLong_FromDouble(floor(x));
}

Expand All @@ -947,7 +947,7 @@ static PyObject *
float___ceil___impl(PyObject *self)
/*[clinic end generated code: output=a2fd8858f73736f9 input=79e41ae94aa0a516]*/
{
double x = PyFloat_AsDouble(self);
double x = PyFloat_AS_DOUBLE(self);
return PyLong_FromDouble(ceil(x));
}

Expand Down