Skip to content

bpo-34790: Implement deprecation of passing coroutines to asyncio.wait() #16977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asvetlov merged 5 commits into from
Dec 30, 2019
Merged

bpo-34790: Implement deprecation of passing coroutines to asyncio.wait() #16977

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6e30ac4
Implement deprecation of passing coros to asyncio.wait()
aeros Oct 29, 2019
b441b27
Add 3.9 whatsnew entry
aeros Oct 29, 2019
42caba2
Fix deprecation message
aeros Oct 29, 2019
0e89978
Add self.assertWarns()
aeros Oct 29, 2019
9a1d2bb
Trim comments
aeros Oct 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Implement deprecation of passing coros to asyncio.wait()
  • Loading branch information
@aeros
aeros committed Oct 29, 2019
commit 6e30ac407e4cb618e4bc883f857380366e8fb682
5 changes: 5 additions & 0 deletions Lib/asyncio/tasks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,6 +421,11 @@ async def wait(fs, *, loop=None, timeout=None, return_when=ALL_COMPLETED):
"and scheduled for removal in Python 3.10.",
DeprecationWarning, stacklevel=2)

if any(coroutines.iscoroutine(f) for f in set(fs)):
warnings.warn("Passing coroutines objects to asyncio.wait() is "
"deprecated since Python 3.8, and scheduled for removal "
"in Python 3.11", DeprecationWarning)

fs = {ensure_future(f, loop=loop) for f in set(fs)}

return await _wait(fs, timeout, return_when, loop)
Expand Down
13 changes: 13 additions & 0 deletions Lib/test/test_asyncio/test_tasks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3307,6 +3307,19 @@ def test_loop_argument_is_deprecated_in_wait_for(self):
self.loop.run_until_complete(
asyncio.wait_for(coroutine_function(), 0.01, loop=self.loop))

def test_coro_is_deprecated_in_wait(self):
# Remove test when passing coros to asyncio.wait() is removed in 3.11
# Test with coro as first arg
with self.assertWarns(DeprecationWarning):
self.loop.run_until_complete(
asyncio.wait([coroutine_function()]))

# Test with coro as second arg
task = self.loop.create_task(coroutine_function())
with self.assertWarns(DeprecationWarning):
self.loop.run_until_complete(
asyncio.wait([task, coroutine_function()]))


class CompatibilityTests(test_utils.TestCase):
# Tests for checking a bridge between old-styled coroutines
Expand Down