Skip to content

bpo-36356: Fix memory leak in _asynciomodule.c during "setup.py build_ext" #16598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1st1 merged 3 commits into from
Oct 7, 2019
Merged

bpo-36356: Fix memory leak in _asynciomodule.c during "setup.py build_ext" #16598

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3f1669e
Fix memory leak during setup.py build_ext
btharper Oct 5, 2019
4a342f9
Ensure asyncio initialization only happens once
btharper Oct 6, 2019
604b615
Fix brackets on else clause
btharper Oct 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix memory leak during setup.py build_ext
  • Loading branch information
@btharper
btharper committed Oct 5, 2019
commit 3f1669e8edb49d4af74f7b7686215973b4766229
8 changes: 6 additions & 2 deletions Modules/_asynciomodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3248,7 +3248,9 @@ module_init(void)
goto fail;
}

current_tasks = PyDict_New();
if (current_tasks == NULL) {
current_tasks = PyDict_New();
}
if (current_tasks == NULL) {
goto fail;
}
Expand All @@ -3259,7 +3261,9 @@ module_init(void)
}


context_kwname = Py_BuildValue("(s)", "context");
if (context_kwname == NULL) {
context_kwname = Py_BuildValue("(s)", "context");
}
if (context_kwname == NULL) {
goto fail;
}
Expand Down