Skip to content

bpo-36670, regrtest: Fix WindowsLoadTracker sampling rate #16555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vstinner wants to merge 1 commit into from
Closed

bpo-36670, regrtest: Fix WindowsLoadTracker sampling rate #16555

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Lib/test/libregrtest/win_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,11 @@

# Max size of asynchronous reads
BUFSIZE = 8192
# Exponential damping factor (see below)
# Seconds per measurement
SAMPLING_INTERVAL = 5
# Exponential damping factor for a sampling interval of 5 seconds (see below)

@ammaraskar ammaraskar Oct 3, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the comment, I should have had this in here originally. I think it might be worth adding a little explanation like:

# Calculated using 1/exp(5sec/1min) = 1/exp(5/60)

the source is https://github.com/torvalds/linux/blob/master/include/linux/sched/loadavg.h#L21

If you feel like 1 second is better, then the new constant would be 0.98347145382161748947374 https://www.wolframalpha.com/input/?i=1%2Fexp%281%2F60%29

LOAD_FACTOR_1 = 0.9200444146293232478931553241

# Seconds per measurement
SAMPLING_INTERVAL = 1
# Windows registry subkey of HKEY_LOCAL_MACHINE where the counter names
# of typeperf are registered
COUNTER_REGISTRY_KEY = (r"SOFTWARE\Microsoft\Windows NT\CurrentVersion"
Expand Down