bpo-38252: use 8-byte step to detect ASCII sequence in 64bit Windows build#16334
Merged
Conversation
Contributor
|
@animalize please resolve the merge conflicts. Thank you! |
Author
|
I have made the requested changes; please review again |
|
Thanks for making the requested changes! : please review the changes made to this pull request. |
serhiy-storchaka
approved these changes
Oct 18, 2020
Member
serhiy-storchaka
left a comment
There was a problem hiding this comment.
LGTM. Please add a NEWS entry.
Author
|
Close and reopen this PR to trigger build bots. |
Author
|
Thanks for your review. |
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In 64-bit Windows builds, C type
unsigned longis 4-byte integer.Now use
size_t, it's 8-byte integer in 64-bit Windows builds.https://bugs.python.org/issue38252