bpo-30389 Adds detection of VS 2017#1632
Merged
Merged
Conversation
|
@zooba, thanks for your PR! By analyzing the history of the files in this pull request, we identified @larryhastings, @briancurtin and @tiran to be potential reviewers. |
pitrou
reviewed
May 28, 2017
Member
There was a problem hiding this comment.
All these functions should be static.
Member
Author
|
Do not merge. The |
Member
Author
Moves COM work onto separate thread.
zware
reviewed
Sep 7, 2017
Member
zware
left a comment
There was a problem hiding this comment.
Looks fine as far as I can tell, but it's mostly beyond me.
Contributor
Contributor
|
Sorry, @zooba and @zooba, I could not cleanly backport this to |
zooba
added a commit
to zooba/cpython
that referenced
this pull request
Sep 7, 2017
zooba
added a commit
that referenced
this pull request
Sep 7, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue30389