Repository navigation
[3.14] gh-161849: Fix crash compiling a class that binds __classdict__ (GH-161933) - #162021
Merged
Merged
Conversation
…_` (pythonGH-161933) When a class body binds __classdict__ (assignment, for target, global, del), analyze_name() treated the name as global in the annotation and type parameter scopes that can see the class, so they no longer got the __classdict__ cell the class creates for them. Compiling such a class with a generic class inside crashed, and with an annotated method or a type alias raised SystemError. Skip that rule for __classdict__ itself. (cherry picked from commit 5131d723d84b7ebca4bcf266cb891f33e51555ef) Co-authored-by: 0z5a <dezhen.lu@student.uni-tuebingen.de>
miss-islington
requested review from
JelleZijlstra and
carljm
as code owners
November 14, 2026 20:47
This was referenced Nov 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a class body binds classdict (assignment, for target, global,
del), analyze_name() treated the name as global in the annotation and
type parameter scopes that can see the class, so they no longer got the
classdict cell the class creates for them. Compiling such a class
with a generic class inside crashed, and with an annotated method or a
type alias raised SystemError.
Skip that rule for classdict itself.
(cherry picked from commit 5131d72)
Co-authored-by: 0z5a dezhen.lu@student.uni-tuebingen.de
__classdict__and contains a generic class #161849