Repository navigation
Conversation
cmaloney
approved these changes
Nov 14, 2026
cmaloney
left a comment
Contributor
There was a problem hiding this comment.
👍 overall; I have a slight preference for keeping the PyObject return because I find that easier to follow than int returns. It may make sense to validate the bytes are actually available/cached in the unicode path.
| Py_ssize_t bytes_len; | ||
| if (b == text) { | ||
| if (PyUnicode_Check(b)) { | ||
| bytes_len = PyUnicode_GET_LENGTH(b); |
Contributor
There was a problem hiding this comment.
Given this function supports text explicitly but requires it has valid cached bytes this branch should check that. Otherwise this will just pass the failure to later in _textiowrapper_writeflush asserts during a flush when we really want to error on a bad argument
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.