Repository navigation
gh-161931: Wake up process manager after spawning workers - #161953
Open
Seemanshi2104 wants to merge 2 commits into
Open
Seemanshi2104 wants to merge 2 commits into
Seemanshi2104 wants to merge 2 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ProcessPoolExecutor.submit()currently wakes the manager thread before spawning a worker. The manager can rebuild its wait set during that gap, leaving it unaware of the new worker's sentinel and unable to promptly detect when that worker exits.This change adjusts the process count before waking the manager. The wake-up remains in a
finallyblock so it still occurs if spawning raises. A synchronized regression test recreates the stale wait-set ordering, terminates the newly spawned worker, and verifies that the pending future raisesBrokenProcessPool.Fixes #161931
Tests:
./python -m test -v test_concurrent_futures.test_process_pool— passed (144 tests, 16 skipped)../python -m test -v test_concurrent_futures.test_deadlock test_concurrent_futures.test_shutdown— passed (101 tests, 2 skipped).spawnandforkserver, and passes with this change.