Skip to content

gh-161735: Update zlib-ng to 2.2.5 on Windows - #161813

Merged
zware merged 2 commits into
python:mainfrom
zware:bump_zlib-ng_windows
Nov 12, 2026
Merged

zware merged 2 commits into
python:mainfrom
zware:bump_zlib-ng_windows

Conversation

@zware

@zware zware commented Nov 11, 2026 •

Copy link
Copy Markdown
Member

@zware
zware requested a review from a team as a code owner November 11, 2026 16:46
@zware zware added type-bug An unexpected behavior, bug, or error OS-windows build The build process and cross-build dependencies Pull requests that update a dependency file needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes labels Nov 11, 2026
@zware

zware commented Nov 11, 2026

Copy link
Copy Markdown
Member Author

@maikschulze, please check that just the version bump is sufficient to address your issue.

@zware
zware requested a review from sethmlarson as a code owner November 11, 2026 17:03
@zooba

zooba commented Nov 11, 2026

Copy link
Copy Markdown
Member

I don't suppose we had a test case for the bug?

@zware

zware commented Nov 11, 2026

Copy link
Copy Markdown
Member Author

IIUC, the symptom is failures of existing tests on certain configurations (which we apparently don't have in CI or buildbots).

@maikschulze

Copy link
Copy Markdown
Contributor

please check that just the version bump is sufficient to address your issue.

Yes, the version bump is enough. I built this PR (dd7fe7c) and its base (0ada998) with PCbuild\build.bat -p x64 --pgo and VS 17.11.3 (MSVC 14.41) on a Ryzen 9 7950X:

  • base (zlib-ng 2.2.4): test_zlib, test_gzip and test_tarfile fail as in the issue (test_decompressmaxlen, test_decompressmaxlenflush, test_write_seek_write, GzipStreamReadTest.test_compare_members)
  • this PR (zlib-ng 2.2.5): test_zlib, test_gzip, test_tarfile and test_zipfile all pass

The zlib-ng-2.2.5 tag in cpython-source-deps has the same files as the upstream 2.2.5 release. Thanks!

@zware

zware commented Nov 12, 2026

Copy link
Copy Markdown
Member Author

Excellent, thanks!

I tried reproducing the failures in a VM on a machine with a Ryzen 9 7900, but I could not match the configuration correctly enough to see the failures myself.

@zware
zware merged commit a969bcf into python:main Nov 12, 2026
101 of 103 checks passed
@zware
zware deleted the bump_zlib-ng_windows branch November 12, 2026 16:35
@miss-islington-app

Copy link
Copy Markdown

Thanks @zware for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15.
🐍🍒⛏🤖

@miss-islington-app

Copy link
Copy Markdown

Sorry, @zware, I could not cleanly backport this to 3.14 due to a conflict.

Please backport manually with cherry_picker, see the devguide for more information.

cherry_picker a969bcf0713caac7ad5366de1eb193cf4ba25a46 3.14

@bedevere-app

bedevere-app Bot commented Nov 12, 2026

Copy link
Copy Markdown

GH-161883 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label Nov 12, 2026
@bedevere-app

bedevere-app Bot commented Nov 12, 2026

Copy link
Copy Markdown

GH-161884 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Nov 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build The build process and cross-build dependencies Pull requests that update a dependency file OS-windows type-bug An unexpected behavior, bug, or error

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants