Repository navigation
gh-161735: Update zlib-ng to 2.2.5 on Windows - #161813
Conversation
|
@maikschulze, please check that just the version bump is sufficient to address your issue. |
|
I don't suppose we had a test case for the bug? |
|
IIUC, the symptom is failures of existing tests on certain configurations (which we apparently don't have in CI or buildbots). |
Yes, the version bump is enough. I built this PR (dd7fe7c) and its base (0ada998) with
The zlib-ng-2.2.5 tag in cpython-source-deps has the same files as the upstream 2.2.5 release. Thanks! |
|
Excellent, thanks! I tried reproducing the failures in a VM on a machine with a Ryzen 9 7900, but I could not match the configuration correctly enough to see the failures myself. |
|
Thanks @zware for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15. |
|
Sorry, @zware, I could not cleanly backport this to Please backport manually with cherry_picker, see the devguide for more information. |
|
GH-161883 is a backport of this pull request to the 3.15 branch. |
|
GH-161884 is a backport of this pull request to the 3.14 branch. |
Uh oh!
There was an error while loading. Please reload this page.