Skip to content

gh-114452: Preserve spaces in synthesized browser paths #159853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
limadog9 wants to merge 1 commit into from
+15 −4
Closed

gh-114452: Preserve spaces in synthesized browser paths #159853

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion Lib/test/test_webbrowser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -563,13 +563,23 @@ def test_get(self):
webbrowser.get('fakebrowser')
self.assertIsNotNone(webbrowser._tryorder)

@unittest.skipIf(" " in sys.executable, "test assumes no space in path (GH-114452)")
def test_synthesize(self):
webbrowser = import_helper.import_fresh_module('webbrowser')
name = os.path.basename(sys.executable).lower()
webbrowser.register(name, None, webbrowser.GenericBrowser(name))
webbrowser.get(sys.executable)

def test_synthesize_space_in_path(self):
webbrowser = import_helper.import_fresh_module('webbrowser')
name = 'testbrowser'
path = os.path.join('path with spaces', name)
webbrowser.register(name, None, webbrowser.GenericBrowser(name))
with mock.patch.object(webbrowser.shutil, 'which', return_value=path) as which:
controller = webbrowser.get(path)
which.assert_called_once_with(path)
self.assertIsInstance(controller, webbrowser.GenericBrowser)
self.assertEqual(controller.name, path)

@unittest.skipIf(
is_apple_mobile,
"Apple mobile doesn't allow modifying browser with environment"
Expand Down
5 changes: 2 additions & 3 deletions Lib/webbrowser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,10 +124,9 @@ def _synthesize(browser, *, preferred=False):
executable for the requested browser, return [None, None].

"""
cmd = browser.split()[0]
if not shutil.which(cmd):
if not shutil.which(browser):
return [None, None]
name = os.path.basename(cmd)
name = os.path.basename(browser)
try:
command = _browsers[name.lower()]
except KeyError:
Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Library/2026-10-20-04-05-00.gh-issue-114452.u6Fq2N.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Fix :mod:`webbrowser` failing to find a registered browser when its executable
path contains spaces.
Loading