Repository navigation
gh-159677: fix FileIO.seekable incorrectly returning false - #159678
Draft
KowalskiThomas wants to merge 2 commits into
Draft
KowalskiThomas wants to merge 2 commits into
KowalskiThomas wants to merge 2 commits into
Conversation
Contributor
Author
|
Seems like the Docs check has flaked :| |
cmaloney
reviewed
Oct 18, 2026
| @@ -0,0 +1,2 @@ | |||
| Fix :meth:`io.FileIO.seekable` always returning ``False`` for a seekable file | |||
Contributor
There was a problem hiding this comment.
seekable and seek are only defined on IOBase in the docs
Lines 422 to 425 in 7dbc797
I would probably do something like:
Fix :class:`io.FileIO` ``seekable`` being cached as false because of an invalid argument to :meth:`!io.FileIO.seek`| Py_END_ALLOW_THREADS | ||
|
|
||
| if (self->seekable < 0) { | ||
| if (self->seekable < 0 && (res >= 0 || errno == ESPIPE || posobj == NULL)) { |
Contributor
There was a problem hiding this comment.
Not sure across the set of OS + kernel + version which Python runs on this is correct... Can work on evaluating that thoroughly but my leaning would be just making it so specific returns we know about that indicate "bad argument" pass through.
For instance EBADF should probably still mark seekable as False / I could see code relying on that. Something like: EINVAL, ENXIO, EOVERFLOW for Linux; EBADF and EINVAL for OpenBSD.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes gh-159677.