Skip to content

gh-159675: Use lazy urllib imports in saxutils #159676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jelly wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −2
Open

gh-159675: Use lazy urllib imports in saxutils #159676

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion Lib/test/test_sax.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,9 @@
import sys
from urllib.error import URLError
import urllib.request
from test.support import os_helper
from test.support import cpython_only, os_helper
from test.support import findfile, check__all__
from test.support import import_helper
from test.support.os_helper import FakePath, TESTFN


Expand Down Expand Up @@ -1600,6 +1601,12 @@ def test_deprecated__version__and__date__(self):
getattr(module, "version")
self.assertEqual(cm.filename, __file__)

Comment thread
jelly marked this conversation as resolved.
@cpython_only
def test_lazy_import(self):
import_helper.ensure_lazy_imports(
"xml.sax.saxutils", {"urllib.parse", "urllib.request"}
)


if __name__ == "__main__":
unittest.main()
4 changes: 3 additions & 1 deletion Lib/xml/sax/saxutils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,9 @@
convenience of application and driver writers.
"""

import os, urllib.parse, urllib.request
import os
lazy import urllib.parse
lazy import urllib.request
import io
import codecs
from . import handler
Expand Down
Loading