Skip to content

Improve test for random.sample and os.renames #159657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ste1hi wants to merge 2 commits into
base: main
Choose a base branch
from
+20 −0
Open

Improve test for random.sample and os.renames #159657

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a78e272
complete test in random.sample
ste1hi Oct 17, 2026
ebb4a7a
Add test for os.renames
ste1hi Oct 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions Lib/test/test_os/test_os.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,6 +233,24 @@ def test_rename(self):
new = sys.getrefcount(path)
self.assertEqual(old, new)

def test_renames(self):
old_path = os_helper.TESTFN + "old_dir"
old = os.path.join(old_path, "test")
os.mkdir(old_path)
open(old, "w+b").close()
self.addCleanup(os_helper.rmdir, old_path)
self.addCleanup(os_helper.unlink, old)

new_path = os_helper.TESTFN + "new_dir"
new = os.path.join(new_path, "test")
self.addCleanup(os_helper.rmdir, new_path)
self.addCleanup(os_helper.unlink, new)

os.renames(old, new)
self.assertTrue(os.path.exists(new))
self.assertFalse(os.path.exists(old))
self.assertFalse(os.path.exists(old_path))

def test_read(self):
with open(os_helper.TESTFN, "w+b") as fobj:
fobj.write(b"spam")
Expand Down
2 changes: 2 additions & 0 deletions Lib/test/test_random.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,8 @@ def test_sample(self):
self.assertRaises(ValueError, self.gen.sample, population, N+1)
self.assertRaises(ValueError, self.gen.sample, [], -1)
self.assertRaises(TypeError, self.gen.sample, population, 1.0)
with self.assertRaises(TypeError):
self.gen.sample(population, 1, counts = [" "] * N)

def test_sample_distribution(self):
# For the entire allowable range of 0 <= k <= N, validate that
Expand Down
Loading