Repository navigation
gh-157259: Record awaited-by edge for asyncio subprocess pipe-connect task - #159556
Open
JohnnyWilson16 wants to merge 1 commit into
Open
JohnnyWilson16 wants to merge 1 commit into
JohnnyWilson16 wants to merge 1 commit into
Conversation
…onnect task When BaseSubprocessTransport creates a task for _connect_pipes(waiter), register the awaited-by relationship between task and waiter so that asyncio.print_call_graph() and asyncio.capture_call_graph() connect the background pipe-connect task to the awaiting parent task. Discard the edge in a done callback once _connect_pipes completes or is cancelled.
JohnnyWilson16
requested review from
1st1,
asvetlov,
kumaraditya303 and
willingc
as code owners
October 16, 2026 16:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes gh-157259.
When
BaseSubprocessTransportspawns an internal task forself._connect_pipes(waiter), the caller awaits thewaiterFuture directly, leaving the internal pipe-connect task disconnected inasyncio.print_call_graph()andasyncio.capture_call_graph().This change registers the awaited-by relationship via
futures.future_add_to_awaited_by(task, waiter)during transport startup and discards the edge in a done callback once_connect_pipesfinishes or is cancelled, ensuring clean disposal with no references leaked.Adds regression test
test_stack_subprocess_connect_pipestotest_asyncio.test_graphunderCallStackTestBase(covering both C and Python call-graph backends).