Repository navigation
gh-159514: Fix tuple item reference leak on resize allocation failure - #159526
Open
zolaski333 wants to merge 2 commits into
Open
zolaski333 wants to merge 2 commits into
zolaski333 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_PyTuple_Resize()frees the tuple storage after a failedPyObject_GC_Resize()without releasing its item references. Release the remaining items before freeing the storage.Py_XDECREF()also handles entries already cleared during shrinking.Add a regression test that forces
MemoryErrorthrough the allocator's checked size limit and verifies that the item is released. It fails before the fix and passes afterwards.The leak was also reproduced by calling
_PyTuple_Resize()directly throughctypes.pythonapi, without_testcapi: the caller's pointer becameNULL, but the item remained alive. The_testcapiwrapper is unchanged.Validation on Windows x64 Debug:
test_capi.test_tuple,test_capi.test_memandtest_tuplepass in the standard build and the free-threaded build with the GIL disabled and enabled.test_capi.test_tuplepasses-R 3:3in both builds.NULLentries.patchcheckandgit diff --checkpass.