Repository navigation
Conversation
Reuse the same code for _requires_unix_version() and _requires_apple_os_version(). Check sys.platform instead of platform.system().
Member
Author
|
cc @encukou |
Member
Author
|
I checked
|
|
🤖 New build scheduled with the buildbot fleet by @encukou for commit ba16058 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F159523%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
Member
|
Looks good! But also OS-specific, so I'd like to ask Buildbot's opinion. |
Member
Author
|
So far, 4 buildbot failed, but for reasons unrelated to this change.
test_lazy_import and test_profiling failed, I created 2 issues:
test_lazy_import failed, same issue.
test_lazy_import failed, same issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reuse the same code for _requires_unix_version() and _requires_apple_os_version().
Check sys.platform instead of platform.system().