Skip to content

Doc: Use walrus operator in example.#15934

Merged
matrixise merged 1 commit into
python:masterfrom
JulienPalard:walrus-example
Sep 11, 2019
Merged

Doc: Use walrus operator in example.#15934
matrixise merged 1 commit into
python:masterfrom
JulienPalard:walrus-example

Conversation

@JulienPalard
Copy link
Copy Markdown
Member

@JulienPalard JulienPalard commented Sep 11, 2019

As proposed in #11441 (review), but I did in two steps so the first could be backported to 3.7 where the example was not working, and this second step for the 3.8 doc with the walrus.

Automerge-Triggered-By: @matrixise

@miss-islington
Copy link
Copy Markdown
Contributor

Thanks @JulienPalard for the PR, and @matrixise for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Copy Markdown
Contributor

Sorry, @JulienPalard and @matrixise, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker e1d455f3a3b82c2e08d5e133bcbab5a181b66cfb 3.8

@miss-islington
Copy link
Copy Markdown
Contributor

Thanks @JulienPalard for the PR, and @matrixise for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Copy Markdown
Contributor

Sorry @JulienPalard and @matrixise, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker e1d455f3a3b82c2e08d5e133bcbab5a181b66cfb 3.8

matrixise pushed a commit to matrixise/cpython that referenced this pull request Sep 11, 2019
(cherry picked from commit e1d455f)

Co-authored-by: Julien Palard <julien@palard.fr>
@bedevere-bot
Copy link
Copy Markdown

GH-15936 is a backport of this pull request to the 3.8 branch.

matrixise added a commit that referenced this pull request Sep 11, 2019
(cherry picked from commit e1d455f)

Co-authored-by: Julien Palard <julien@palard.fr>
@JulienPalard JulienPalard deleted the walrus-example branch September 11, 2019 13:40
DinoV pushed a commit to DinoV/cpython that referenced this pull request Sep 12, 2019
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants