Repository navigation
gh-158095: Fix reference cycles in re scanners - #158100
Merged
Merged
Conversation
eendebakpt
reviewed
Sep 24, 2026
Assisted-by: Codex:GPT-6
eendebakpt
approved these changes
Sep 25, 2026
eendebakpt
left a comment
Contributor
There was a problem hiding this comment.
Thanks @YangSiJun528.
|
Thanks @YangSiJun528 for the PR, and @eendebakpt for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
|
Thanks @YangSiJun528 for the PR, and @eendebakpt for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15. |
|
GH-161245 is a backport of this pull request to the 3.14 branch. |
|
GH-161246 is a backport of this pull request to the 3.15 branch. |
eendebakpt
pushed a commit
that referenced
this pull request
Nov 3, 2026
…61246) gh-158095: Fix reference cycles in re scanners (GH-158100) * Fix reference cycles in re scanners * 📜🤖 Added by blurb_it. * gh-158095: Normalize NEWS line endings * gh-158095: Clear input references in re scanners * ci: rerun checks Assisted-by: Codex:GPT-6 --------- (cherry picked from commit 8c3b566) Co-authored-by: sijun-yang <yangsijun5528@gmail.com> Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
eendebakpt
pushed a commit
that referenced
this pull request
Nov 3, 2026
…61245) gh-158095: Fix reference cycles in re scanners (GH-158100) * Fix reference cycles in re scanners * 📜🤖 Added by blurb_it. * gh-158095: Normalize NEWS line endings * gh-158095: Clear input references in re scanners * ci: rerun checks Assisted-by: Codex:GPT-6 --------- (cherry picked from commit 8c3b566) Co-authored-by: sijun-yang <yangsijun5528@gmail.com> Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #158095.
Visit the owned references in
state.stringandstate.buffer.objfromscanner_traverse()so cycles involvingre.finditer()andPattern.scanner()can be collected.Add a regression test for
re.finditer()withstrandbytearraysubclasses. The test fails before the fix and passes after it.AI assistance: Codex helped investigate, implement, test, and draft this PR.
re.finditer()leaks reference cycles through its input #158095