Skip to content

bpo-38043: Move unicodedata.normalize tests into test_unicodedata. #15712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benjaminp merged 2 commits into from
Sep 10, 2019
Merged

bpo-38043: Move unicodedata.normalize tests into test_unicodedata. #15712

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f35cdac
bpo-38043: Move unicodedata.normalize tests into test_unicodedata.
gnprice Sep 6, 2019
8803950
Fold old test_normalize function in too, as test_edge_cases.
gnprice Sep 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fold old test_normalize function in too, as test_edge_cases.
  • Loading branch information
@gnprice
gnprice committed Sep 10, 2019
commit 8803950b0ce524df2c77d851e5cdd2a52c4c366a
11 changes: 5 additions & 6 deletions Lib/test/test_unicodedata.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,12 +172,6 @@ def test_combining(self):
self.assertRaises(TypeError, self.db.combining)
self.assertRaises(TypeError, self.db.combining, 'xx')

def test_normalize(self):
self.assertRaises(TypeError, self.db.normalize)
self.assertRaises(ValueError, self.db.normalize, 'unknown', 'xx')
self.assertEqual(self.db.normalize('NFKC', ''), '')
# See also comprehensive tests in NormalizationTest below.

def test_pr29(self):
# http://www.unicode.org/review/pr-29.html
# See issues #1054943 and #10254.
Expand Down Expand Up @@ -399,6 +393,11 @@ def NFKD(str):
continue
self.assertTrue(X == NFC(X) == NFD(X) == NFKC(X) == NFKD(X), c)

def test_edge_cases(self):
self.assertRaises(TypeError, unicodedata.normalize)
self.assertRaises(ValueError, unicodedata.normalize, 'unknown', 'xx')
self.assertEqual(unicodedata.normalize('NFKC', ''), '')

def test_bug_834676(self):
# Check for bug 834676
unicodedata.normalize('NFC', '\ud55c\uae00')
Expand Down