Skip to content

bpo-38038: Remove urllib.parse._splittype from xmlrpc.client. #15703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serhiy-storchaka merged 3 commits into from
Sep 8, 2019
Merged

bpo-38038: Remove urllib.parse._splittype from xmlrpc.client. #15703

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5fa6cb5
bpo-38038: Remove urllib.parse._xxxx fromxmlrpc.client.
corona10 Sep 5, 2019
b793503
Update code
corona10 Sep 5, 2019
eca5086
bpo-38038: Apply codereview
corona10 Sep 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions Lib/xmlrpc/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1421,15 +1421,14 @@ def __init__(self, uri, transport=None, encoding=None, verbose=False,
# establish a "logical" server connection

# get the url
type, uri = urllib.parse._splittype(uri)
if type not in ("http", "https"):
p = urllib.parse.urlparse(uri)
if p.scheme not in ("http", "https"):
raise OSError("unsupported XML-RPC protocol")
self.__host, self.__handler = urllib.parse._splithost(uri)
if not self.__handler:
self.__handler = "/RPC2"
self.__host = p.netloc
self.__handler = p.path or "/RPC2"

if transport is None:
if type == "https":
if p.scheme == "https":
handler = SafeTransport
extra_kwargs = {"context": context}
else:
Expand Down