Repository navigation
gh-156980: Fix asyncio call graph truncation at async generators - #156984
Open
deadlovelll wants to merge 1 commit into
Open
deadlovelll wants to merge 1 commit into
deadlovelll wants to merge 1 commit into
Conversation
deadlovelll
requested review from
1st1,
asvetlov,
kumaraditya303,
markshannon and
willingc
as code owners
September 5, 2026 14:37
Documentation build overview
|
msullivan
reviewed
Oct 2, 2026
msullivan
left a comment
Contributor
There was a problem hiding this comment.
This looks good to me!
Comment on lines
+1241
to
+1248
| The awaitables returned by :meth:`~agen.asend`, :meth:`~agen.athrow` and | ||
| :meth:`~agen.aclose` expose the generator they drive as a read-only | ||
| ``ag_gen`` attribute. | ||
|
|
||
| .. versionadded:: 3.16 | ||
| The ``ag_gen`` attribute. | ||
|
|
||
|
|
Contributor
There was a problem hiding this comment.
Probably document it in Doc/library/inspect.rst, rather than here, I think.
1st1
approved these changes
Oct 7, 2026
1st1
left a comment
Member
There was a problem hiding this comment.
I don't think this is controversial at all and it can help with building better debugging tools.
Member
|
@pablogsal @ambv -- this one is beneficial for async introspection, can we backport it? |
msullivan
reviewed
Oct 8, 2026
| } | ||
|
|
||
| static PyMemberDef async_gen_asend_memberlist[] = { | ||
| {"ag_gen", Py_T_OBJECT_EX, offsetof(PyAsyncGenASend, ags_gen), Py_READONLY}, |
Contributor
There was a problem hiding this comment.
Oh, maybe do we want to call the field ags_gen?
I don't feel strongly at all though.
Contributor
There was a problem hiding this comment.
Actually probably nevermind: I think it's good to have the throw and send ones use the same name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix asyncio call graph truncation at async generators
For more details see gh-156980