gh-82039: relax cookiejar.py case-sensitive regex for the inconsequential first line of the cookie file - #15673

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Our records indicate we have not received your CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

Apologies if I'm being obtuse, but, my PR has been in the queue for 3.5 years. Is there anything I need to do to get this approved and merged in?

@ashleyharvey Could you sign the new CLA by clicking not signed button in the cpython-cla-bot's message, please?

@ashleyharvey Could you sign the new CLA by clicking not signed button in the cpython-cla-bot's message, please?

Done, I think? I got an internal server error multiple times but looking at the bot's comment above now, it says it's signed.

Bump

This PR is stale because it has been open for 30 days with no activity.

GNU wget 1.25.0 writes # HTTP Cookie File, so the original motivation is gone, but it will not harm to make the check more lenient — files written by older versions are still around.

Please add re.ASCII. Without it re.IGNORECASE enables full Unicode case folding, so these match too:

>>> re.compile("#( Netscape)? HTTP Cookie File", re.I).match("# Netſcape HTTP Cookie File")  # U+017F
<re.Match object; span=(0, 27), match='# Netſcape HTTP Cookie File'>
>>> re.compile("#( Netscape)? HTTP Cookie File", re.I).match("# Netscape HTTP CooKie File")  # U+212A
<re.Match object; span=(0, 27), match='# Netscape HTTP CooKie File'>

LWPCookieJar.magic_re already uses re.ASCII.

Please also add a test. test_bad_magic only covers rejection, so nothing would catch a regression here.

Thanks @globalshrug for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15.
🐍🍒⛏🤖

GH-155580 is a backport of this pull request to the 3.15 branch.

GH-155581 is a backport of this pull request to the 3.14 branch.

GH-155582 is a backport of this pull request to the 3.13 branch.