gh-156570: handle lazy warnings import in test helper - #156573
Open
mikemikimike wants to merge 4 commits into
Open
gh-156570: handle lazy warnings import in test helper#156573mikemikimike wants to merge 4 commits into
mikemikimike wants to merge 4 commits into
Conversation
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #156570
Summary
warnings_helper._filterwarnings()indexedsys.modules['warnings']directly. Under-X lazy_imports=all, evaluating the module-level import can leave that entry unresolved, causingcheck_warnings()to raiseKeyError.Use the already imported module as a fallback when the
warningsentry is absent, and add regression coverage for this state.Testing
python Lib/test/test_warnings_helper.pypython -m py_compile Lib/test/support/warnings_helper.py Lib/test/test_warnings_helper.pygit diff --checkCompatibility
The change preserves the existing module replacement behavior used by
test_warningswhile avoiding aKeyErrorwhen lazy imports have not populatedsys.modules.AI assistance was used to identify the issue and prepare this patch.