Skip to content

gh-156555: Fix crash in sqlite3.Row() with uninitialised Cursor #156556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aisk wants to merge 1 commit into
base: main
Choose a base branch
from
+16 −0
Open

gh-156555: Fix crash in sqlite3.Row() with uninitialised Cursor #156556

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions Lib/test/test_sqlite3/test_factory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,6 +280,12 @@ class FakeCursor(str):
self.assertRaises(TypeError, self.con.cursor, FakeCursor)
self.assertRaises(TypeError, sqlite.Row, FakeCursor(), ())

def test_uninitialised_cursor(self):
cur = sqlite.Cursor.__new__(sqlite.Cursor)
with self.assertRaisesRegex(sqlite.ProgrammingError,
"Base Cursor.__init__ not called"):
sqlite.Row(cur, ())


class TextFactoryTests(MemoryDatabaseMixin, unittest.TestCase):

Expand Down
3 changes: 3 additions & 0 deletions Misc/NEWS.d/next/Library/2026-08-29-18-52-43.gh-issue-156555.nNV61R.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Fix a crash in :class:`sqlite3.Row` when it is given a
:class:`sqlite3.Cursor` whose ``__init__()`` was not called; it now raises
:exc:`sqlite3.ProgrammingError` instead.
7 changes: 7 additions & 0 deletions Modules/_sqlite/row.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,13 @@ pysqlite_row_new_impl(PyTypeObject *type, pysqlite_Cursor *cursor,

assert(type != NULL && type->tp_alloc != NULL);

if (!cursor->initialized) {
pysqlite_state *state = pysqlite_get_state_by_type(type);
PyErr_SetString(state->ProgrammingError,
"Base Cursor.__init__ not called.");
return NULL;
}

self = (pysqlite_Row *) type->tp_alloc(type, 0);
if (self == NULL)
return NULL;
Expand Down
Loading