gh-56959: Add cross-platform support for %s strftime-format code - #155964
Open
imabd645 wants to merge 3 commits into
Open
gh-56959: Add cross-platform support for %s strftime-format code#155964imabd645 wants to merge 3 commits into
imabd645 wants to merge 3 commits into
Conversation
Documentation build overview
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds cross-platform support for the
%sformat code (UNIX timestamp, representing the number of seconds since the Epoch) in thedatetimemodule'sstrftimewrapper.On Unix,
%sis natively supported by the underlying C runtime library, while on Windows it is typically not supported and varies unpredictably. This patch normalizes the behavior by intercepting%sinternally fordatetimeinstances, guaranteeing cross-platform consistency.make_sreplacementinModules/_datetimemodule.cto handle the conversion before passing the format to the native platformstrftime()C function.Lib/_pydatetime.py).%scovering timezone-aware and naive timestamps, including negative pre-epoch timestamps, toLib/test/datetimetester.py.strftime()formatting table and footnotes inDoc/library/datetime.rst.