gh-150942: Improve performance of csv reader by using _PyList_AppendT… - #155957
Open
imabd645 wants to merge 1 commit into
Open
gh-150942: Improve performance of csv reader by using _PyList_AppendT…#155957imabd645 wants to merge 1 commit into
imabd645 wants to merge 1 commit into
Conversation
Contributor
|
Duplicate of #150995? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the performance of the
csvmodule's reader by replacing standardPyList_Appendcalls with the internal_PyList_AppendTakeRefstealing method.When parsing CSV fields, the C extension previously appended the parsed field to a list and subsequently decremented the reference count of the field. By using the new stealing methods, we avoid the overhead of an unnecessary incref/decref pair and slightly simplify the C implementation.
Changes:
"pycore_list.h"inModules/_csv.c.PyList_Appendfollowed byPy_DECREFwith_PyList_AppendTakeRefin theparse_save_fieldfunction.NEWSblurb.