gh-69573: Check return value of msvcrt_putch and msvcrt_putwch - #155956
Closed
imabd645 wants to merge 2 commits into
Closed
gh-69573: Check return value of msvcrt_putch and msvcrt_putwch#155956imabd645 wants to merge 2 commits into
imabd645 wants to merge 2 commits into
Conversation
Member
|
It looks like only a NEWS entry file was added. Did something go wrong with your Git operations? |
Member
|
It looks like this issue was already addressed by #154364, so this PR duplicates that work. I'll close this PR along with the original issue. Thank you for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a longstanding bug in the
msvcrtmodule where the return values of the underlying Windows_putchand_putwchfunctions were ignored.According to the Windows C Runtime documentation, these functions return
EOF(orWEOF) when an error occurs (such as when the console is unattached or output is redirected improperly). Because the Python wrappers (msvcrt.putchandmsvcrt.putwch) previously returnedNoneunconditionally, these errors were silently swallowed.Changes:
EOFinmsvcrt_putch_impl.WEOFinmsvcrt_putwch_impl.OSErrorviaPyErr_SetFromErrno(PyExc_OSError).NEWSblurb.