gh-155946: Improve error handling in SMTP email logging - #155950

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

How do I add the NEWS entry? And also, am I able to use the original issuer's test? His code for reproducing was:

logging.raiseExceptions = False
open_conns = []

def handle(conn):
    conn.sendall(b"220 fake ESMTP\r\n")
    for line in conn.makefile("rb"):
        cmd = line.strip().upper()
        if cmd.startswith(b"EHLO"):
            conn.sendall(b"250-fake\r\n250 AUTH PLAIN LOGIN\r\n")
        elif cmd.startswith(b"AUTH"):
            conn.sendall(b"535 authentication failed\r\n")
        else:
            conn.sendall(b"250 ok\r\n")
    open_conns.remove(conn)  # reached when the client closes the connection
    conn.close()

def serve(listener):
    while True:
        conn, _ = listener.accept()
        open_conns.append(conn)
        threading.Thread(target=handle, args=(conn,), daemon=True).start()

listener = socket.create_server(("127.0.0.1", 0))
threading.Thread(target=serve, args=(listener,), daemon=True).start()

h = logging.handlers.SMTPHandler(("127.0.0.1", listener.getsockname()[1]),
                                 "me@example.com", "you@example.com", "subject",
                                 credentials=("user", "wrong-password"))
for i in range(5):
    h.emit(logging.makeLogRecord({"msg": "hello"}))  # SMTPAuthenticationError
time.sleep(0.5)
print("open connections after 5 failed emits:", len(open_conns))
gc.collect(); time.sleep(0.5)
print("after gc.collect():", len(open_conns))

How do I add the NEWS entry

Use https://blurb-it.herokuapp.com/ or write it yourself with python -m blurb (I suggest using the app).

And also, am I able to use the original issuer's test

I beléieve so but you may also want to clean it up and have a minimal working example instead. You should also read the existing tests first.

Do I just add the tests into the description of the PR or just leave a comment with the test(s)?

Do I just add the tests into the description of the PR or just leave a comment with the test(s)?

I don't understand. The PR description isn't really relevant as long as we have the issue.

You must add tests inside Lib/test/test_logging.py (look at the files)

Sorry, got confused. Everything should be done now.