gh-155944: Catch only expected errors in getDOMImplementation fallback - #155948
Closed
tobiaspal wants to merge 1 commit into
Closed
gh-155944: Catch only expected errors in getDOMImplementation fallback#155948tobiaspal wants to merge 1 commit into
tobiaspal wants to merge 1 commit into
Conversation
…allback Don't catch all exceptions from the `well_known_implementations` candidates, because only the expected `ImportError` and `AttributeError` mean the implementation is unavailable.
Member
|
See #155944 (comment) for rationale of closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't catch all exceptions from the
well_known_implementationscandidates, because only the expectedImportErrorandAttributeErrormean the implementation is unavailable.Found via @devdanzin's AI-assisted audit of
Lib/; working on it at the PyCon Korea 2026 sprint.In
well_known_implementationsthexml.dom.DOMImplementationseems to be a leftover from PyXML, so onlyxml.dom.minidomis used (comes fromLib/xml/dom/minidom.py):cpython/Lib/xml/dom/domreg.py
Lines 11 to 14 in b6c11fe
Claude Code helped write the tests and the fix.
xml.dom.domreg.getDOMImplementation: fallback discovery masks genuine bugs, not just "not installed" #155944