gh-155941: Close the transport when a plain client_connected_cb raises - #155942
Open
danielKim614 wants to merge 1 commit into
Open
gh-155941: Close the transport when a plain client_connected_cb raises#155942danielKim614 wants to merge 1 commit into
danielKim614 wants to merge 1 commit into
Conversation
danielKim614
requested review from
1st1,
asvetlov,
kumaraditya303 and
willingc
as code owners
August 17, 2026 07:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a plain-function
client_connected_cbpassed toasyncio.start_server()raises,StreamReaderProtocol.connection_made()now reports the error via the loop exception handler and closes the transport, mirroring what gh-111601 (gh-110894) did for coroutine callbacks.Previously the exception propagated out of
connection_made(), so the server-side transport stayed open forever, leaking the connection and makingServer.wait_closed()hang. The error was also reported with the generic callback message instead of"Unhandled exception in client_connected_cb".The new test fails without the fix and passes with it. The full
test_asynciosuite passes, including-R 3:3refleak runs ontest_streams.cc. Pycon 2026 KR Sprint @hugovk @corona10