gh-150942: Speed up re.split result building - #155940
Merged
Merged
Conversation
…ence-stealing list append
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
corona10
approved these changes
Aug 17, 2026
corona10
left a comment
Member
There was a problem hiding this comment.
FYI, You don't need NEWS.d for optimization for most of case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@hugovk @corona10
Append result items to the output list with
_PyList_AppendTakeRefinstead ofPyList_Appendfollowed byPy_DECREF, removing a reference-count round-tripper appended item (and a per-append lock on the free-threaded build). This is
the same change gh-150943 made to
re.findallandre.sub/subn, applied tothe one result-building loop it left behind. The
error:label only dropslist, and_PyList_AppendTakeRefsteals the reference on failure too, so theerror path is unchanged.
Microbenchmarks
Default build
re_splitre_split_groupsre_split_wsre_split_bytesstr_split_controlFree-threading build
re_splitre_split_groupsre_split_wsre_split_bytesstr_split_controlBenchmark script