gh-155925: Narrow except Exception in typing Protocol helpers - #155930
Closed
lovit wants to merge 1 commit into
Closed
gh-155925: Narrow except Exception in typing Protocol helpers#155930lovit wants to merge 1 commit into
lovit wants to merge 1 commit into
Conversation
…r) in typing Protocol helpers _get_protocol_attrs and _proto_hook caught bare Exception around __annotations__ access, silently swallowing unrelated errors along with the legitimate AttributeError/NameError cases. Narrow the catch to (AttributeError, NameError) so genuine bugs propagate instead of being hidden.
|
All commit authors signed the Contributor License Agreement. |
Member
|
I wrote it this way intentionally. Evaluating annotations can execute arbitrary code, and it is correct to fall back to FORWARDREF format in such cases. |
Author
|
Thanks for the explanation, that makes sense. I confirmed locally that a function call inside an annotation can raise more than just I'll close this PR. Thanks for taking the time to explain. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes gh-155925.
Narrows
except Exceptiontoexcept (AttributeError, NameError)in_get_protocol_attrsand_proto_hook.AttributeErroralone regresses the deferred-evaluation tests, soNameErroris needed too.Added 4 regression tests; full
test_typingsuite passes locally.