gh-155596: Fix pprint expand mode ignoring width for nested values - #155926
Open
cobed95 wants to merge 1 commit into
Open
gh-155596: Fix pprint expand mode ignoring width for nested values#155926cobed95 wants to merge 1 commit into
cobed95 wants to merge 1 commit into
Conversation
|
All commit authors signed the Contributor License Agreement. |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
pprint(..., expand=True)'s "best effort" for adhering towidth=...seems not very "best" #155596Summary
In the new "expand" mode,
'key':prefix needs to be accounted for.Here we add a new argument
prefix_lento_format, andmax_widthso that width is respected.indentso that existing behaviour is preserved.Tests
One new test was added and two existing tests' expectations have been updated.
Existing expectations were violating the
width=40setting, so I would like to regardthese updates not as regressions, but rather as corrections.
pprint(..., expand=True)'s "best effort" for adhering towidth=...seems not very "best" #155596