gh-150942: Optimize stringlib split/splitlines with _PyList_AppendTakeRef - #155922
Open
danielKim614 wants to merge 2 commits into
Open
gh-150942: Optimize stringlib split/splitlines with _PyList_AppendTakeRef#155922danielKim614 wants to merge 2 commits into
danielKim614 wants to merge 2 commits into
Conversation
…e-150942.sTrSpL.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Append result items to the output list with
_PyList_AppendTakeRefinstead ofPyList_Appendfollowed byPy_DECREFin the stringlibSPLIT_ADD(past the 12-slot prealloc) andSPLIT_APPEND(used bysplitlines()for every line) macros, removing a reference-count round-trip per appended item (and a per-append lock on the free-threaded build). This coverssplit/rsplit/splitlinesforstr,bytesandbytearray. The result list is freshly allocated and stays local to the split function until it is returned.Microbenchmarks
str_split_10k_pieces("abc " * 10_000).split(" ")str_split_whitespace_10k("word " * 10_000).split()str_splitlines_10k("line\n" * 10_000).splitlines()bytes_split_10k_pieces(b"abc " * 10_000).split(b" ")test_strandtest_bytespass, including-R 3:3refleak runs.Benchmark script