[3.13] gh-130094: Fix race conditions in importlib (gh-130101) - #155915
Merged
Conversation
zsaladin
requested review from
brettcannon,
ericsnowcurrently,
ncoghlan and
warsaw
as code owners
August 17, 2026 02:05
Contributor
Author
|
@hugovk I made a PR! Thank you for your help! |
…130101) Entries may be added or removed from `sys.meta_path` concurrently. For example, setuptools temporarily adds and removes the `distutils` finder from the beginning of the list. The local copy ensures that we don't skip over any entries. Some packages modify `sys.modules` during import. For example, `collections` inserts the entry for `collections.abc` into `sys.modules` during import. We need to ensure that we re-check `sys.modules` *after* the parent module is fully initialized. (cherry picked from commit 857bdba) Co-authored-by: Sam Gross <colesbury@gmail.com>
zsaladin
force-pushed
the
backport-857bdba-3.13
branch
from
August 17, 2026 02:15
67c0bf0 to
f45ca68
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Entries may be added or removed from
sys.meta_pathconcurrently. For example, setuptools temporarily adds and removes thedistutilsfinder from the beginning of the list. The local copy ensures that we don't skip over any entries.Some packages modify
sys.modulesduring import. For example,collectionsinserts the entry forcollections.abcintosys.modulesduring import. We need to ensure that we re-checksys.modulesafter the parent module is fully initialized.(cherry picked from commit 857bdba)