gh-155907: Raise OSError and KeyboardInterrupt when reading marshal data - #155909
Open
serhiy-storchaka wants to merge 1 commit into
Open
gh-155907: Raise OSError and KeyboardInterrupt when reading marshal data#155909serhiy-storchaka wants to merge 1 commit into
serhiy-storchaka wants to merge 1 commit into
Conversation
…shal data Reading marshalled data from a FILE* did not check ferror() nor signals, so an I/O error or a Ctrl-C was reported as EOFError. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Documentation build overview
|
Member
Author
|
Failure on Windows is expected -- this is a bug #155905. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r_string(),r_byte()andPyMarshal_ReadLastObjectFromFile()did not checkferror()nor callPyErr_CheckSignals(), so a genuine I/O error or a read interrupted by Ctrl-C was reported asEOFError, as if the file had simply ended.The documentation of these functions listed only
EOFError,ValueErrorandTypeError, which was inaccurate even before this change (MemoryErroris raised when the read buffer cannot be allocated), so the lists are removed.