gh-155905: Fix error handling in _testcapi helpers - #155906
Open
serhiy-storchaka wants to merge 1 commit into
Open
gh-155905: Fix error handling in _testcapi helpers#155906serhiy-storchaka wants to merge 1 commit into
serhiy-storchaka wants to merge 1 commit into
Conversation
Py_fopen() sets an exception and returns NULL on error. The pyobject_print*() helpers did not check the result and crashed, and the pymarshal_*() helpers set a second exception on top of it. The pyobject_print*() helpers which take a single argument now use METH_O, and the result of PyUnicode_FromString() is now checked. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Py_fopen()sets an exception and returnsNULLon error.The
pyobject_print*()helpers inModules/_testcapi/object.cdid not check the result and passed aNULLfile pointer toPyObject_Print(), which segfaulted. Thepymarshal_*()helpers inModules/_testcapimodule.ccalledPyErr_SetFromErrno()on top of the exception whichPy_fopen()had already set, which raisedSystemErroron a release build and aborted a debug build.The
pyobject_print*()helpers which take a single argument are converted toMETH_O, and the unchecked result ofPyUnicode_FromString()is checked.